Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Managed Identity ACI Prefect Worker recipe #238

Closed
wants to merge 14 commits into from
Closed

Add Managed Identity ACI Prefect Worker recipe #238

wants to merge 14 commits into from

Conversation

prefectcboyd
Copy link
Contributor

Description

What's cooking?

This recipe adds files, configuration, and README for provisioning a Prefect ACI Worker and Managed Identity.
Steps are provided for each component - it is intended to be used for a private repository, where identity is used to retrieve credentials from a KeyVault instead of secrets within Prefect.
It can be used without identity, solely as an instructional setup for ACI.

New Recipe Checklist

  • My PR is in the format of Add <project-name> recipe
  • My recipe is reproducible and explains everything needed to run successfully. If my code has external dependencies, I make mention of them.
  • My code is easily understandable and/or well-commented.
  • If my recipe requires a new category (e.g. creating a monitoring/ folder in devops/), I have encapsulated my project within its own subfolder so that others can add their own recipes as well.
  • If my recipe uses Prefect < 2.0, my code is within the prefect-v1-legacy/ folder.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 28, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@serinamarie
Copy link
Contributor

Moving this to draft until @prefectcboyd finds a reviewer.

@serinamarie serinamarie marked this pull request as draft November 28, 2023 15:08
@serinamarie
Copy link
Contributor

Closing but feel free to reopen anytime @prefectcboyd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabcoyne gabcoyne Awaiting requested review from gabcoyne gabcoyne is a code owner

@jamiezieziula jamiezieziula Awaiting requested review from jamiezieziula jamiezieziula is a code owner

@EmilRex EmilRex Awaiting requested review from EmilRex EmilRex is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prefectcboyd @serinamarie @jsopkin